Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P PanTools
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 32
    • Issues 32
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • bioinformatics
  • PanTools
  • Merge requests
  • !86

Fix -H double role as file and list of groups

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Workum, Dirk-Jan van requested to merge fix_homology_file_msa into pantools_v3.5 Nov 02, 2022
  • Overview 48
  • Commits 12
  • Pipelines 11
  • Changes 14

The issue that arose was the -H is used for both homology group files and homology group identifiers according to the code. However, the argument parsing assumed it always was a file. We should therefore split the argument based on what it means.

I let -H be used for homology group files and -G for a list of homology groups. Both are comma-separated still. I also created an ArgGroup class for them being mutually exclusive. NB: I introduced one unresolved issue: providing a string to -G gives a weird error message that I cannot handle with bean validation?

  • Fix weird error message with -G and a non-integer input.

IMPORTANT: This is a merge request to the pantools_v3.5 branch, which will later on be merged into master.

Edited Nov 03, 2022 by Workum, Dirk-Jan van
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix_homology_file_msa